Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Development in partial pipeline demo #156

Closed
wants to merge 15 commits into from

Conversation

ajeklund
Copy link
Contributor

@ajeklund ajeklund commented Jul 13, 2023

Description:

This PR incorporates the changes of oteapi-dlite that were introduced in the partial pipeline demo given in the MatCHMaker General Assembly meeting on 2023-06-29. It was based on oteapi-dlite v0.1.2 but master is now at v0.1.3., so this branch needs to be rebased before the changes can be properly reviewed.

Type of change:

  • Bug fix.
  • New feature.
  • Documentation update.

Checklist for the reviewer:

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand, including clearly named variables?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?

@ajeklund ajeklund linked an issue Jul 13, 2023 that may be closed by this pull request
@ajeklund ajeklund marked this pull request as draft July 13, 2023 13:51
This was referenced Jul 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2023

Codecov Report

Attention: 111 lines in your changes are missing coverage. Please review.

Comparison is base (a5f90f1) 87.29% compared to head (224a3e4) 69.21%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #156       +/-   ##
===========================================
- Coverage   87.29%   69.21%   -18.08%     
===========================================
  Files          15       17        +2     
  Lines         425      536      +111     
===========================================
  Hits          371      371               
- Misses         54      165      +111     
Flag Coverage Δ
linux 69.21% <0.00%> (-18.08%) ⬇️
windows 69.04% <0.00%> (-18.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
oteapi_dlite/strategies/parse_excel.py 89.85% <ø> (ø)
oteapi_dlite/strategies/parse_txt.py 0.00% <0.00%> (ø)
oteapi_dlite/strategies/parse_mpr.py 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Treesarj
Copy link
Contributor

@ajeklund please review ! I have added just two parsers- I am not sure that this can be reused. Pls check and maybe we should just delete this PR

@CasperWA CasperWA closed this Feb 26, 2024
@CasperWA CasperWA deleted the 155-changes-from-partial-pipeline-demo branch February 26, 2024 14:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorporate development from partial pipeline demo
4 participants