Have file updates trigger RSS changes and Subscription actions. #248
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dataset updates triggered by file changes using the watch system did not trigger RSS or subscriptions. This is counter to user expectations. The stated reasoning in a code comment was to avoid spammy changes for datasets that change frequently. I also did not see an explanation for users about this behavior. So this change is bringing the RSS and subscription systems in line with both the documentation and user expectations.
I recognize that this changes behavior in a way that could cause excessive notifications and/or load. There is a new parameter "updateSubsRssOnFileChanges" that will allow admins to disable this behavior if needed.
Documentation will be added once the big documentation update is settled.
Fixes #237
Type of change
Please delete options that are not relevant.
Checklist before requesting a review