Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Capitalization of obs4MIPs in recipes #2337

Open
remi-kazeroni opened this issue Oct 8, 2021 · 2 comments
Open

Capitalization of obs4MIPs in recipes #2337

remi-kazeroni opened this issue Oct 8, 2021 · 2 comments

Comments

@remi-kazeroni
Copy link
Contributor

Is your feature request related to a problem? Please describe.
In #1217 the obs4mips project was renamed obs4MIPs. While reviewing that PR, I was prompted to edit my config-user.yml file to account for that change. Using the Core and Tool in dev mode, I have just checked that one could still run recipes (e.g recipe_smpi.yml) containing datasets with project: obs4mips. I just wanted to make sure that recipes with project: obs4mips would still be supported in the next release. Also, would it be better to capitalize obs4MIPs correctly in all our recipes? What do you think @bouweandela?

Would you be able to help out?
Would you have the time and skills to implement the solution yourself? yes

@hb326
Copy link
Contributor

hb326 commented Oct 11, 2021

I was just running a recipe where I was asked to rename the "obs4mips" to "obs4MIPs". However, the recipe still needs "ana4mips" un-capitalized. I think if we change the "MIP" to be capitalized, it should also be capitalized in "ana4mips" to be consistent.

@bouweandela
Copy link
Member

Also, would it be better to capitalize obs4MIPs correctly in all our recipes?

Yes, I think so, but the old capitalization will continue to work.

I think if we change the "MIP" to be capitalized, it should also be capitalized in "ana4mips" to be consistent.

Good point, could you please open an issue in ESMValCore about it?

What is the status of the ana4MIPs project, it seems a bit dated? For example, we're also missing the ana4MIPs CMOR tables in the core and I did not add download support for it.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

3 participants