Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add php 7.3 support #63

Closed
PatelUtkarsh opened this issue Dec 7, 2018 · 6 comments
Closed

Add php 7.3 support #63

PatelUtkarsh opened this issue Dec 7, 2018 · 6 comments

Comments

@PatelUtkarsh
Copy link

Add support PHP 7.3 as it's officially available.

https://twitter.com/official_php/status/1070753276939960320

This can be optional support like ee3.

@michacassola
Copy link

Move to feature-request?

@PatelUtkarsh PatelUtkarsh transferred this issue from EasyEngine/easyengine Dec 7, 2018
@mrrobot47
Copy link
Member

mrrobot47 commented Dec 10, 2018

PHP 7.3.0 support will be added very soon. Once it is added, @rahul286 @PatelUtkarsh @rahulsprajapati what should be the default PHP version when a site is created using EasyEngine?

Currently, EasyEngine creates a site uses PHP 7.2.12 if no specific --php=<version> flag is passed. What should be the default behaviour now that the current stable PHP version is 7.3.0?

  1. Continue creating sites with PHP 7.2.12 by default?
  2. Update to last stable of 7.2 family, i.e., PHP 7.2.13 and use it as default?
  3. Switch to the current stable PHP 7.3.0 as the default PHP version as well as update --php=7.2 to latest 7.2.13?

Note: The supported PHP versions during installations will soon be populated to all the versions listed here under section PHP version update for Site type PHP and WP.

@PatelUtkarsh
Copy link
Author

I would prefer point 2. We can use 7.3 as default after few releases. @mrrobot47

@rahulsprajapati
Copy link

Yep, keep the default php version to 7.2 and add support of other php7 versions to --php flag. As @PatelUtkarsh said we can update the default after few releases.

@gijo-varghese
Copy link

Any updates on this?

@kirtangajjar
Copy link

Support for php 7.3 has been added.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants