Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Refactor column picker typing #245

Open
PowerKiKi opened this issue Nov 11, 2023 · 0 comments
Open

Refactor column picker typing #245

PowerKiKi opened this issue Nov 11, 2023 · 0 comments

Comments

@PowerKiKi
Copy link
Member

PowerKiKi commented Nov 11, 2023

Refactor as described below for easier usage. Because the only non-ES2020 project is Dilps and we don't use ColumnPicker there.

* Implementation details:
*
* Unfortunately, we cannot use a `Record<AvailableColumn>` where keys would implicitly be unique and would replace
* this ID property, because only ES2020 guarantee the order of object keys, and we must still support ES2015 for
* iPhone 6. So, instead of `Record<AvailableColumn>`, we use `AvailableColumn[]` for now. But this could be
* revisited once we drop support of ES2015.
*
* @see https://stackoverflow.com/questions/30076219/does-es6-introduce-a-well-defined-order-of-enumeration-for-object-properties

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant