This repository was archived by the owner on Jan 29, 2024. It is now read-only.
(feat): add baseCountryCode option for normalizing phonenumbers #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
baseCountryCode
option, when it is defined the (E.164) normalized phonenumbers are resolved.Usage
Implements/uses:
Reason
Having native code implement/run complicated libraries seemed (more) efficient. The reason for implementing this here is because Android used to return the NORMALIZED_NUMBER. But it does not anymore and taking it further with E.164 has advantages.
Other
I do not have a strong opinion if this functionality belongs here perse, it might be nice to have. But there are certainly arguments against it. Feel free to ignore/close this PR/proposal.