Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update Zashi Theme #1555

Open
Milan-Cerovsky opened this issue Aug 19, 2024 · 1 comment
Open

Update Zashi Theme #1555

Milan-Cerovsky opened this issue Aug 19, 2024 · 1 comment

Comments

@Milan-Cerovsky
Copy link
Contributor

Milan-Cerovsky commented Aug 19, 2024

Is your feature request related to a problem? Please describe.

  • Once new zashi theme design system is done remove and replace ExchangeRateColors
  • Add dimensions to theme & replace existing ones in exchange rates
@HonzaR
Copy link
Collaborator

HonzaR commented Aug 19, 2024

I'd not necessarily remove it. We could just make this class internal and consume it within the ui-design-lib module, as we do for, e.g., TopAppBarColors or ButtonColors. The main goal of this task should be extracting commonly used colors to values as we do in Colors.kt. See comments here and here.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants