Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Define who's the recipient of a shielding transaction #521

Closed
pacu opened this issue Sep 6, 2022 · 2 comments
Closed

Define who's the recipient of a shielding transaction #521

pacu opened this issue Sep 6, 2022 · 2 comments
Labels
bug Something isn't working high-severity

Comments

@pacu
Copy link
Contributor

pacu commented Sep 6, 2022

Function Shield funds calls initSpend

public func shieldFunds(
        transparentAccountPrivateKey: TransparentAccountPrivKey,
        memo: String?,
        from accountIndex: Int,
        resultBlock: @escaping (Result<PendingTransactionEntity, Error>) -> Void
    ) 

Which requires a recipient Address
let shieldingSpend = try transactionManager.initSpend(zatoshi: tBalance.verified, toAddress: zAddr, memo: memo, from: 0)

There's no such string encoded recipient address for shielding transactions, since Internal Addresses are not string encoded since they are not intended to be displayed to users.

@pacu pacu added bug Something isn't working high-severity labels Sep 6, 2022
@nuttycom nuttycom mentioned this issue Sep 6, 2022
14 tasks
@nuttycom
Copy link
Contributor

The recipient of the shielding operation is the account index that's being provided here. The wallet front-end might want to do something where it allows users to provide friendly names for accounts, so that it's not just wallet internal account 1 or whatever.

@nuttycom nuttycom added this to the UAs in Mobile SDKs milestone Oct 6, 2022
@pacu
Copy link
Contributor Author

pacu commented Oct 23, 2022

closed in #567

@pacu pacu closed this as completed Oct 23, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working high-severity
Projects
None yet
Development

No branches or pull requests

2 participants