Skip to content

Weight needs to be cached for OP_TXWEIGHT #1031

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
roconnor-blockstream opened this issue Sep 2, 2021 · 1 comment
Closed

Weight needs to be cached for OP_TXWEIGHT #1031

roconnor-blockstream opened this issue Sep 2, 2021 · 1 comment
Assignees
@apoelstra

Comments

@roconnor-blockstream
Copy link
Contributor

The operation GetSerializeSize is O(transaction_size) instead of O(1). Thus this value need to be cached.

61b5152#diff-a0337ffd7259e8c7c9a7786d6dbd420c80abfa1afdb34ebae3261109d9ae3c19R2426-R2431
@roconnor-blockstream roconnor-blockstream mentioned this issue Sep 4, 2021
Merged
@apoelstra
Copy link
Member

apoelstra commented Sep 5, 2021 •
edited
Loading

Closed by #1032

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@apoelstra apoelstra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@apoelstra @roconnor-blockstream