Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

General fixes to install script #1219

Closed
wants to merge 4 commits into from
Closed

Conversation

phra
Copy link

@phra phra commented Sep 3, 2018

installing empire as non-root user will fail where sudo is not used.

phra added 3 commits September 4, 2018 01:21
installing empire as non-root user will fail where sudo is not used.
@phra phra changed the title fix: use sudo everywhere in install.sh General fixes to install script Sep 3, 2018
@phra
Copy link
Author

phra commented Sep 3, 2018

supersedes #1211

Copy link

@bisack bisack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You changed the package on line 140, but failed to update the package name on 141 to match. If you run the setup script like this, you still get an error that libssl1.0.0_1.0.1t-1+deb8u7_amd64.deb cannot be found.
When I fixed this locally and re-tried, I got the following dpkg warning:
dpkg: warning: downgrading libssl1.0.0:amd64 from 1.0.1t-1+deb8u9 to 1.0.1t-1+deb8u8.

@phra
Copy link
Author

phra commented Oct 31, 2018

@bisack thanks for the comment, i will fix it later.

@phra
Copy link
Author

phra commented Oct 31, 2018

@bisack fixed. can you please check and change your review status? thanks.

@bisack
Copy link

bisack commented Nov 2, 2018

@phra -- While the current version is indeed deb8u9 - that url is incorrect and results in a 404 error. I found 8u8 DOES work, and resolves some of the issues I ran into.

In order to unblock my own workflow, I created a fork so I could re-enable my environment auto-builds. That change and two others (to fix the powershell installation failure and the urllib3 version issue) make up my pull request.

See #1268 for the changes I made.

Edit: Apologies for my somewhat stumbling/sloppy contributions, I'm still trying to get a grasp on the whole github thing.

Copy link

@bisack bisack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phra -- While the current version is indeed deb8u9 - that url results in a 404 error. I found 8u8 DOES work, and resolves libssl issues I had. My suggestion would be to either move to 8u8 or find a working package URL for 8u9.

@phra
Copy link
Author

phra commented Nov 2, 2018

@bisack i am going to close this PR in favor of #1268. thanks for your contribution.

@phra phra closed this Nov 2, 2018
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants