Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Typos in definition of 'ocean' (ENVO:00000015) #1550

Open
dillerm opened this issue Nov 7, 2024 · 2 comments
Open

Typos in definition of 'ocean' (ENVO:00000015) #1550

dillerm opened this issue Nov 7, 2024 · 2 comments

Comments

@dillerm
Copy link

dillerm commented Nov 7, 2024

Current definition: "A marine water body which is constitutes the majority of an astronomical body's hydrosphere." (emphasis mine)

Proposed fix: "A saline water body which constitutes the majority of an astronomical body's hydrosphere."

@cmungall
Copy link
Member

cmungall commented Nov 7, 2024

Thanks for noticing the typo!

Regarding marine vs saline, can you say more about the motivation? Is it because "marine" is more circular?

  • Many definitions of "marine" are something like "sea or ocean"
  • ENVO's own definition of "marine water body" is "A lentic water body which is composed primarily of marine water.", but we have no term "marine water" in ENVO

There are some other oddities here. In ENVO, marine WB and saline WB are sibs, but surely it should be child-parent

Here are the terms in context:

image

@dillerm
Copy link
Author

dillerm commented Nov 7, 2024

Ah, whoops, I had not noticed that this class had 'marine water body' as a parent class (I was only looking at 'saline water body'). Ignore that suggestion.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants