Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Guid support #396

Open
xnf opened this issue Dec 19, 2024 · 4 comments
Open

Guid support #396

xnf opened this issue Dec 19, 2024 · 4 comments

Comments

@xnf
Copy link

xnf commented Dec 19, 2024

Is your feature request related to a problem? Please describe.
Hi. I would like to use Guid and quick search over the issues for a word "guid" showed at least two issues where people mention their own wrappers for guid.
I may be exaggerating but guid (v7 in particular) is a pretty common/popular these days. Don't take my word for it, i don't have the evidence.
While listening to to some of A.Zimarev presentations in Youtube, i may overheard that he is not interested in guid (again, with all due respect, i don't have evidence and i dont want to listen those hours of talk for something that perhaps was not even said).

Describe the solution you'd like
I know people here have their wrappers for guid->string->guid conversion. I have one too. If there is a popular demand and conceptual approve from the Eventuous leadership, i may contribute mine and then we talk.

Describe alternatives you've considered

  1. having my own wrapper.
  2. mapping back and froth as seen in this closed issue Using MapDiscoveredCommands with multiple aggregates results in error 'No handler found for command Object ' #264 _ => new CarId(Guid.NewGuid().ToString())

Additional context
I recently discovered Eventuous. Love it.

Copy link

linear bot commented Dec 19, 2024

EVE-190 Guid support

Copy link
Contributor

I am a bit confused, where do you want to support GUID?

@bl-hashdex
Copy link

probably on Mongo projections that require by default a string Id.

@alexeyzimarev
Copy link
Contributor

Yeah but Mongo projections work just fine 🤷‍♂️.

I kind of get a gist of it that maybe the thought is to use GUID instead of typed identity. Eventuous used to use strings for that purpose. The issue is that it weakens the type system. Or, maybe, the idea is to use GUID as the identity value, but it is limiting because a GUID can be converted to a string but not every string can be converted to a GUID. And, identity could be anything. Like, hashed email or ip address.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants