feat: Add Comments tab to User Profile #653
Conversation
LulaV14
commented
Apr 4, 2022
LulaV14
commented
| const userComments = await Comment.query() | ||
| .where('authorId', user.userId) | ||
| .innerJoin('insight', 'comment.insightId', 'insight.insightId') | ||
| .whereNull('insight.deletedAt') |
There was a problem hiding this comment.
Probably need to add .whereNull('comment.deletedAt') here.
packages/backend/schema.gql
Outdated
| cursor: String! | ||
| cursor: String |
There was a problem hiding this comment.
How did this change happen?
There was a problem hiding this comment.
This was probably done when I was testing, but I'm not sure why it didn't revert back.
| @@ -86,7 +86,7 @@ export const InsightList = ({ | |||
| ); | |||
| } | |||
|
|
|||
| if (insightConnection.edges.length === 0) { | |||
| if (insightConnection.edges?.length === 0) { | |||
There was a problem hiding this comment.
edges are not nullable, so not sure why this is needed?
There was a problem hiding this comment.
you're right, I'm not sure how I suddenly got an error from here, seems like insightConnection shouldn't be undefined either at this point.
But I couldn't replicate it anymore, so maybe I'll just remove it from here and create a ticket if it happens again
LulaV14
changed the title
## [3.8.0](v3.7.0...v3.8.0) (2022-04-07) ### Features * Add Comments tab to User Profile ([#653](#653)) ([dc3db70](dc3db70))
|
🎉 This PR is included in version 3.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
