Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[$250] [Chore] Bump react-native-reanimated to 3.16.1 #52024

Open
blazejkustra opened this issue Nov 5, 2024 · 7 comments
Open

[$250] [Chore] Bump react-native-reanimated to 3.16.1 #52024

blazejkustra opened this issue Nov 5, 2024 · 7 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor

Comments

@blazejkustra
Copy link
Contributor

blazejkustra commented Nov 5, 2024

This issue aims to update react-native-reaniamted to the newest version because of two reasons:

  1. Workletization of react-native-live-markdown, requires that we have latest version installed + it blocks [Autocomplete] Highlight autocomplete key and selected value
  2. Starting from this versions, there is a new API for shared values that is compatible with react-compiler. More info here
Issue OwnerCurrent Issue Owner: @eVoloshchak
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021853942849461570206
  • Upwork Job ID: 1853942849461570206
  • Last Price Increase: 2024-11-05
@blazejkustra blazejkustra added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Nov 5, 2024
Copy link

melvin-bot bot commented Nov 5, 2024

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@blazejkustra blazejkustra changed the title Bump react-native-reanimated to 3.16.1 [Chore] Bump react-native-reanimated to 3.16.1 Nov 5, 2024
@Julesssss
Copy link
Contributor

Hey @blazejkustra. FYI, to prevent the crash from blocking us on staging we did a minor bump here today.

@luacmartins luacmartins self-assigned this Nov 5, 2024
@luacmartins
Copy link
Contributor

Assigning myself since this change affects Search - #50949

@luacmartins luacmartins added the External Added to denote the issue can be worked on by a contributor label Nov 5, 2024
@melvin-bot melvin-bot bot changed the title [Chore] Bump react-native-reanimated to 3.16.1 [$250] [Chore] Bump react-native-reanimated to 3.16.1 Nov 5, 2024
Copy link

melvin-bot bot commented Nov 5, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021853942849461570206

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 5, 2024
@luacmartins luacmartins removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 5, 2024
Copy link

melvin-bot bot commented Nov 5, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

@blazejkustra
Copy link
Contributor Author

blazejkustra commented Nov 6, 2024

Update: I created a draft PR with the update, however I hit a wall because there are crashes after the upgrade, I let the reanimated team know and they are working on it (here is an upstream issue).

Also FYI I'm OOO 7-11 November, so I'll come back to this after the break.

@luacmartins
Copy link
Contributor

Thanks for the update @blazejkustra! Enjoy your time off.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

5 participants