Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Tag Applauseleads when a pull request is CP'd #7178

Closed
roryabraham opened this issue Jan 12, 2022 · 3 comments
Closed

Tag Applauseleads when a pull request is CP'd #7178

roryabraham opened this issue Jan 12, 2022 · 3 comments
Assignees
Labels
Engineering Improvement Item broken or needs improvement. Monthly KSv2 Reviewing Has a PR in review

Comments

@roryabraham
Copy link
Contributor

Action Performed:

CP a PR by label or manually.

Expected Result:

Applauseleads should be tagged on the checklist and the new PR should be added to the checklist.

Actual Result:

Applauseleads are not tagged when a new PR is CP'd.

Workaround:

Manually manage the checklist when PRs are CP'd.

Platform:

GitHub only.

Version Number: 1.1.29-2

@roryabraham
Copy link
Contributor Author

Interestingly, this became much easier with the paradigm shift introduced in #7166. Since the app's PATCH version is only bumped when a PR is first created, that means the BUILD version is only bumped when we CP a PR.

@MelvinBot MelvinBot removed the Overdue label Feb 17, 2022
@roryabraham
Copy link
Contributor Author

Since the app's PATCH version is only bumped when a PR is first created, that means the BUILD version is only bumped when we CP a PR.

Whoops, actually that's not true – the BUILD version will also be bumped when any PR is merged while the checklist is unlocked.

@roryabraham
Copy link
Contributor Author

Got a draft PR almost completely ready, but having an issue with our new linter.

@roryabraham roryabraham added the Reviewing Has a PR in review label Feb 19, 2022
@botify botify closed this as completed Feb 23, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Engineering Improvement Item broken or needs improvement. Monthly KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

3 participants