Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[NO QA] Adding payment type const #823

Merged
merged 1 commit into from
Dec 20, 2024
Merged

[NO QA] Adding payment type const #823

merged 1 commit into from
Dec 20, 2024

Conversation

rlinoz
Copy link
Contributor

@rlinoz rlinoz commented Dec 20, 2024

Adding payment type const since that we are using it more.

Fixed Issues

https://github.com/Expensify/Expensify/issues/454091

https://github.com/Expensify/Web-Expensify/pull/44860#discussion_r1893221330

Tests

  1. What unit/integration tests cover your change? What autoQA tests cover your change?
  2. What tests did you perform that validates your changed worked?

QA

  1. What does QA need to do to validate your changes?
  2. What areas to they need to test for regressions?

@rlinoz rlinoz self-assigned this Dec 20, 2024
@rlinoz rlinoz requested a review from a team as a code owner December 20, 2024 15:33
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 20, 2024 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@rlinoz
Copy link
Contributor Author

rlinoz commented Dec 20, 2024

I have read the CLA Document and I hereby sign the CLA

@melvin-bot melvin-bot bot requested review from blimpich and removed request for a team December 20, 2024 15:33
CLABotify added a commit to Expensify/CLA that referenced this pull request Dec 20, 2024
@CLABotify
@rlinoz has signed the CLA in Expensify/expensify-common#823
38088ae
NikkiWines
NikkiWines approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@NikkiWines NikkiWines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@NikkiWines NikkiWines merged commit 86db781 into main Dec 20, 2024
6 checks passed
@NikkiWines NikkiWines deleted the rodrigo-add-payment-type-const branch December 20, 2024 15:39
@os-botify
Copy link
Contributor

os-botify bot commented Dec 20, 2024

🚀 Published to npm in 2.0.110 🎉

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@NikkiWines NikkiWines NikkiWines approved these changes

@blimpich blimpich Awaiting requested review from blimpich

Assignees

@rlinoz rlinoz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rlinoz @NikkiWines