New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Code style in the tests #41

Closed

FHof opened this issue Feb 24, 2022 · 1 comment

Owner

FHof commented Feb 24, 2022 •

edited

Loading

I think it is possible to change the tests code so that it is easier to read and maintain:

Currently the tests use sys.path.append for the imports instead of importing torchquad, so __init__.py is not executed.
It may be possible to shorten the code by replacing the setup_test_for_backend with parameterized tests.
utils_integration_test.py shows warnings while the other code uses pytest skips if a backend is not installed. The code could be changed so that pytest skips are used everywhere.

Some of these changes may however make it more difficult to support the execution of the test files with python3 in addition to pytest.

The text was updated successfully, but these errors were encountered:

FHof changed the title ~~Pytests code style~~ Code style in the tests

Owner Author

FHof commented Apr 30, 2022

Moved to esa#144

FHof closed this as completed

# for free to join this conversation on GitHub. Already have an account? # to comment