feat: add grafana datasource for psql #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennydaman
requested changes
Nov 9, 2022
|
I thought I had changed the ini format to yaml syntax but looks like I
missed pushing that commit, let me fix it.
…On Wed, 9 Nov 2022 at 19:50, Jennings Zhang ***@***.***> wrote:
***@***.**** requested changes on this pull request.
I don't think it makes sense to mix YAML and INI config syntax.
—
Reply to this email directly, view it on GitHub
<#15 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANF3CEAATHIAGRZZW2HCQITWHOXJRANCNFSM6AAAAAARVY7DYM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
@jennydaman It is fixed now, please take a look. Ini & datasources are two different files which can't be merged, idk why I configured it in the helm-chart way where you can merge ini in your values.yaml. |
jennydaman
requested changes
Nov 14, 2022
| @@ -284,6 +284,7 @@ services: | |||
| volumes: | |||
| - grafana_data:/var/lib/grafana | |||
| - ./grafana.ini:/etc/grafana/grafana.ini:ro | |||
| - ./provisionaning:/etc/grafana/provisioning | |||
There was a problem hiding this comment.
the dir name contains a typo, would you fix this?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #14