New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Missed cast for fraction long value #7

Open

liach opened this issue May 25, 2020 · 1 comment

Labels

bug

Contributor

liach commented May 25, 2020

FluidApi/src/main/java/io/github/fablabsmc/fablabs/api/fluid/v1/math/Fraction.java

Line 307 in 75c1ecd

return (int) (numerator / denominator);

liach added the bug label

Contributor

LemmaEOF commented May 25, 2020

oh right, since we changed to longs. We're gonna be changing this because of #5 leaning towards whole+ints at the moment, so we'll see.

# for free to join this conversation on GitHub. Already have an account? # to comment