Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

New moonboard app doesn't light up green blue lights #12

Closed
sintoris opened this issue Oct 17, 2023 · 7 comments
Closed

New moonboard app doesn't light up green blue lights #12

sintoris opened this issue Oct 17, 2023 · 7 comments

Comments

@sintoris
Copy link

I finished building my mini moonboard last week, just about when the new moonboard app was released. The old app works great with this project. With the new app, only the start (green/violet) and finish (red) holds are lighted up. The holds in between remain dark.

Any clues as to what could be wrong?

PS: Thanks for this great project!

@sintoris sintoris changed the title New moonboard up doesn't light up green blue lights New moonboard app doesn't light up green blue lights Oct 17, 2023
@sintoris
Copy link
Author

This was easy to fix. Just changed "P" to "R" in main.cpp:157 and :198.

In the new moonboard app the progress holds are marked with "R". In the old app it was with "P".

For example, for the problem "70-250!" the problem strings are:
Old app Problem string: S74,S114,P39,P103,E11,E60
New app Problem string: S74,S114,R39,R103,E11,E60

@FabianRig
Copy link
Owner

Thanks for letting us know! I assume you're using an iPhone? I don't remember seeing an update for my Android device.

I'm on vacation at the moment and don't have access to my laptop. Therefore I can't fix it right now.

However, I'd suggest we change both lines to an OR statement and check for both P and R. Like that, the project works with any version.

@sintoris
Copy link
Author

sintoris commented Oct 19, 2023

No I am using Android. The old app has been silently removed from the play store last week. A new app has appeared with slightly different icon. One can actually have them both installed side by side but only if you have had installed the old app before last week. Confusingly the version numbering has restarted from 1.x with the new app. The old one stopped at 8.something.

I think there is no need to keep both P and R in the code. First, one cannot install the old app anymore. Second, even if you have the old app installed, you can't log any sent problems with it anymore. At least that's the case with me.

@marcosncosta1
Copy link

Nice catch. I am about to start on the project. I will make the changes in the code as suggested

@OllieCMartin
Copy link

The new app introduces 'show move beta', @sintoris is right about just changing "P" to "R" during normal operation, but when show beta is on you get additional holds/colours:

"L" -> lefthand
"R" -> Righthand
"M" -> Match hands
"F" -> footholds

so you have S, R, L, M, F, E hold types now!

Easy enough to fix, I'm not sure what the right colours should be so I ended up just making them up!

@FabianRig
Copy link
Owner

FabianRig commented Oct 29, 2023

Thank you all for bringing this up!

I've found some new problems with included beta and updated the code accordingly.

It should work as expected now. Please let me know if you encounter any issues!

@FabianRig
Copy link
Owner

I'm closing this issue because it should be fixed. Feel free to open a new one if there are any issues.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants