Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Added color extension to core #442

Merged
merged 1 commit into from
Jan 29, 2022
Merged

Added color extension to core #442

merged 1 commit into from
Jan 29, 2022

Conversation

pimjansen
Copy link

@pimjansen pimjansen commented Jan 28, 2022 •
edited
Loading

What is the reason for this PR?

Added core extension from legacy to core

  • A new feature
  • Fixed an issue (resolve #ID)

Author's checklist

Summary of changes

n/a

Review checklist

  • All checks have passed
  • Changes are approved by maintainer

@pimjansen pimjansen force-pushed the feature/color-extension-to-core branch from cbf6b6c to ee893ad Compare January 29, 2022 09:36
@pimjansen pimjansen marked this pull request as ready for review January 29, 2022 09:37
@pimjansen pimjansen requested a review from bram-pkg January 29, 2022 09:37
@pimjansen pimjansen force-pushed the feature/color-extension-to-core branch from ee893ad to 586c077 Compare January 29, 2022 09:38
bram-pkg
bram-pkg approved these changes Jan 29, 2022
View reviewed changes
Copy link
Member

@bram-pkg bram-pkg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bram-pkg bram-pkg merged commit fbc273b into FakerPHP:main Jan 29, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@bram-pkg bram-pkg bram-pkg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pimjansen @bram-pkg