New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

$famous.find finds only one element #80

Closed

jagoe opened this issue Jun 2, 2014 · 1 comment · Fixed by #86

jagoe commented Jun 2, 2014

The method $famous.find(selector) finds just one element, since it uses element.querySelector instead of element.querySelectorAll.

134 var elems = angular.element(window.document.querySelector(selector));

should be

134 var elems = angular.element(window.document.querySelectorAll(selector));

The text was updated successfully, but these errors were encountered:

Contributor

ocombe commented Jun 2, 2014

You're right, could you do a PR ?
Otherwise I'll do it tonight.

ocombe mentioned this issue

fix: allow $famous.find to return multiple elements #86

Merged

zackbrown closed this as completed in #86

# for free to join this conversation on GitHub. Already have an account? # to comment