Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

RPS is not deterministic and not seeded correctly. #1223

Open
1 task done
MiladInk opened this issue Jul 16, 2024 · 1 comment
Open
1 task done

RPS is not deterministic and not seeded correctly. #1223

MiladInk opened this issue Jul 16, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@MiladInk
Copy link

Describe the bug

I am just running the rock paper scissor example of pettingzoo here. I found out if I run the code multiple times, I get different plays. This is a bug. I think it is because the passed seed is not used at all in the code. However, I am not sure how we seed the environments in petting zoo. In Gym, we seed, and then use the env.np_seed to generate stuff if IIRC.

Code example

No response

System info

No response

Additional context

No response

Checklist

  • I have checked that there is no similar issue in the repo
@MiladInk MiladInk added the bug Something isn't working label Jul 16, 2024
@MiladInk
Copy link
Author

MiladInk commented Jul 16, 2024

I am also finding out that the RSP parallel example is using
observation, infp = env.reset()
while reset returns nothing.

I can fix this one and make a pull request but don't know where the tutorial resides in the repo.

Edit: I currently understand what is going on. The example code is actually converting the environment from a parallel environment to an AEC one. However, the code that is provided right after that in the tutorial is assuming a parallel environment. This is scary! Is petting zoo not supported well? I didn't expect to run into these problems in the tutorial 😨

@David-GERARD David-GERARD self-assigned this Nov 22, 2024
@David-GERARD David-GERARD added this to the 1.24.4 release milestone Dec 9, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants