Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Sequence Not Found error is not sent back to MQTT RPC Client #1496

Open
jsimmonds2 opened this issue Jun 23, 2022 · 0 comments
Open

Sequence Not Found error is not sent back to MQTT RPC Client #1496

jsimmonds2 opened this issue Jun 23, 2022 · 0 comments

Comments

@jsimmonds2
Copy link
Contributor

jsimmonds2 commented Jun 23, 2022

Was playing around with the farmbot-js package today and noticed that {:error, "sequence not found"} cases aren't handled and just display on the FBOS Console log ( via stderr ? ) instead of being bundled up and returned to the the RPC Client as other errors are, so my JS program just quietly hangs ⏲️ . . .

There's an argument, I suppose, that I should enumerate all Sequences and check that the desired Sequence Id is available before trying to schedule it for execution, but the race condition there still exists ! ( that sequence can be deleted before I try to schedule it )

Here's the error splashed onto the IEx console 🙁

image

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant