Time zone aware lenient parsing #343
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ObjectReader reader = READER.with(TimeZone.getTimeZone(Z_BUDAPEST)); | ||
| Instant instant = Instant.parse("2024-07-21T22:00:00Z"); | ||
| LocalDate value = reader.readValue('"' + instant.toString() + '"'); | ||
| assertEquals("The value is not correct.", LocalDate.parse("2024-07-22"), value); |
There was a problem hiding this comment.
I think this is wrong and against the semantics of LocalDate.
|
I'll continue discussion on #342 but basically I do not agree with the change as is. Mis-using In this case you will probably need to register custom deserializer to solve your use case. |
|
I understand your objections. Then let's close this one. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #342.
The current implementation of lenient parsing of
LocalDateandLocalDateTimewas implemented with the goal to always produce the values such that they need to be interpreted to be UTC.In particular for
LocalDatethis can very easily lead to confusing behavior for users.The proposed change only leads to a change in behavior when the
TimeZoneis explicitly set on theObjectMapperand is different fromUTC.