You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
as of now, due to the usage of response.type,response.send and so on, this exception filter only works for http adapters that implements such methods on their response object. Express and Fastify has them but 3rd-party http adapters might not have (because they aren't needed for nestjs core AFIAK)
at same time, as we need to inject that dependency into the HttpExceptionFilter, there's no way to add this feature without introducing a breaking change because now one will need to supply that new parameter when using the app.useGlobalFilters bind approach (like described here)
so yeah, it's up to you 😄
btw I'd like to contribute to this project because of Hacktoberfest :p
The text was updated successfully, but these errors were encountered:
hi! good lib!
as of now, due to the usage of
response.type
,response.send
and so on, this exception filter only works for http adapters that implements such methods on their response object. Express and Fastify has them but 3rd-party http adapters might not have (because they aren't needed for nestjs core AFIAK)nest-problem-details/libs/nest-problem-details-filter/src/filters/http-exception.filter.ts
Lines 55 to 66 in 43ad7c9
My suggestion is using the
HttpAdapterHost
instead like the docs shows here: https://docs.nestjs.com/exception-filters#catch-everythingat same time, as we need to inject that dependency into the
HttpExceptionFilter
, there's no way to add this feature without introducing a breaking change because now one will need to supply that new parameter when using theapp.useGlobalFilters
bind approach (like described here)so yeah, it's up to you 😄
btw I'd like to contribute to this project because of Hacktoberfest :p
The text was updated successfully, but these errors were encountered: