Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

mirror window watermark #49

Open
jkbr-19 opened this issue Sep 23, 2024 · 2 comments
Open

mirror window watermark #49

jkbr-19 opened this issue Sep 23, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@jkbr-19
Copy link

jkbr-19 commented Sep 23, 2024

I often find myself confused when messing with wl-mirror. I sometimes can't tell when where the wl-mirror is and where the real windows are. So I would find the following related features useful.

  • a permanent watermark, available as an option, with a set spot to mark the wl-mirror window
  • a temporary visual signal, to mark the wl-mirror window. Could be triggered by a keyboard shortcut or anytime mirroring begins

while typing this i realize reverse features might be useful as well

  • a visual signal, briefly flashing on the borders of the window/region/monitor being mirrored
@Ferdi265 Ferdi265 added the enhancement New feature or request label Sep 23, 2024
@Ferdi265
Copy link
Owner

I often find myself confused when messing with wl-mirror. I sometimes can't tell when where the wl-mirror is and where the real windows are. So I would find the following related features useful.

* a permanent watermark, available as an option, with a set spot to mark the wl-mirror window

* a temporary visual signal, to mark the wl-mirror window. Could be triggered by a keyboard shortcut or anytime mirroring begins

This is currently quite a lot to implement, since wl-mirror at the moment has no UI toolkit and no input handling, which would add quite a lot of boilerplate. Simple keyboard shortcuts on the window or mouse-based region selection are what I want to add to wl-mirror in the long run though, so at some point the infrastructure needed for this will be there, likely not in the near future though.

while typing this i realize reverse features might be useful as well

* a visual signal, briefly flashing on the borders of the window/region/monitor being mirrored

The reverse is harder to implement, since wl-mirror doesn't have any special privileges and can only do what a normal Wayland client can do. On wlroots compositors, a recording symbol could be created on the captured output with something like wlr-layer-shell, but this would only work on the whole monitor and not on a window / region.

Good suggestions overall though, but both not easy to simply implement.

@progandy
Copy link

This is currently quite a lot to implement, since wl-mirror at the moment has no UI toolkit and no input handling, which would add quite a lot of boilerplate.

A minimal implementation could be flashing the window gray or perform some other egl operations using a command received via pipe.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants