Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Benchmarks Fail in Forked PRs #45

Closed
SkyeHoefling opened this issue Jan 6, 2022 · 0 comments · Fixed by #49
Closed

Benchmarks Fail in Forked PRs #45

SkyeHoefling opened this issue Jan 6, 2022 · 0 comments · Fixed by #49

Comments

@SkyeHoefling
Copy link
Contributor

Description

When a community member submits a pull request, they will most likely fork this repository and then submit the PR. Right now the benchmarks fail to checkout code correctly from the forked repo. This is due to how the ref is piped from the first build to the next. It assumes that it is retrieving the ref from the origin repository and doesn't take into account forked repositories.

Root Cause

The benchmark.yml build checks if it is a new PR or been requested to run via the check-command job. It will then store the current git ref and pass that value to the next job benchmark-build. This job will try and checkout the code and compile, but it assumes that it is checking out the origin repo. If the PR is a forked repository then the checkout command will fail.

Build Log from #42

Fetching the repository
  "C:\Program Files\Git\bin\git.exe" -c protocol.version=2 fetch --no-tags --prune --progress --no-recurse-submodules --depth=1 origin +refs/heads/libjpeg-turbo*:refs/remotes/origin/libjpeg-turbo* +refs/tags/libjpeg-turbo*:refs/tags/libjpeg-turbo*
  The process 'C:\Program Files\Git\bin\git.exe' failed with exit code 1
  Waiting 14 seconds before trying again
  "C:\Program Files\Git\bin\git.exe" -c protocol.version=2 fetch --no-tags --prune --progress --no-recurse-submodules --depth=1 origin +refs/heads/libjpeg-turbo*:refs/remotes/origin/libjpeg-turbo* +refs/tags/libjpeg-turbo*:refs/tags/libjpeg-turbo*
  The process 'C:\Program Files\Git\bin\git.exe' failed with exit code 1
  Waiting 13 seconds before trying again
  "C:\Program Files\Git\bin\git.exe" -c protocol.version=2 fetch --no-tags --prune --progress --no-recurse-submodules --depth=1 origin +refs/heads/libjpeg-turbo*:refs/remotes/origin/libjpeg-turbo* +refs/tags/libjpeg-turbo*:refs/tags/libjpeg-turbo*
  Error: The process 'C:\Program Files\Git\bin\git.exe' failed with exit code 1

Proposed Changes

Update the benchmark.yml to work with forked repositories

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant