Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Update of social media hyperlinks in the footer required #70

Open
tmsagarofficial opened this issue Oct 4, 2023 · 4 comments · May be fixed by #78
Open

Update of social media hyperlinks in the footer required #70

tmsagarofficial opened this issue Oct 4, 2023 · 4 comments · May be fixed by #78
Assignees
@nandanpi @tmsagarofficial
Labels
good first issue Good for newcomers low-priority low priority issue compared to others already present

Comments

@tmsagarofficial
Copy link

I would like to point out that all the social media links such as Instagram. facebook etc.
image
when clicked upon them these links open in the same tab as the current tab. I really feel that making sure that these links open in a separate or new tab would contribute towards user experience and also maintain a good flow for the user.

Pls assign this issue to me so that I can work on the same under hacktoberfest
@nagarajpandith
Copy link
Member

you can go ahead if you think inserting target="_blank" is really a valuable contribution. we will accept it.
along with this, it'd be nice if you can find out and replace the usage of next/link on non-external links in this project like these social links. keep it only for the internal routes.

@nagarajpandith nagarajpandith added good first issue Good for newcomers low-priority low priority issue compared to others already present labels Oct 15, 2023
@tmsagarofficial
Copy link
Author

@nagarajpandith Thanks for assigning will start working on it

@tmsagarofficial
Copy link
Author

you can go ahead if you think inserting target="_blank" is really a valuable contribution. we will accept it. along with this, it'd be nice if you can find out and replace the usage of next/link on non-external links in this project like these social links. keep it only for the internal routes.

I didn't get this part of next/link ... can u please eloborate....

@tmsagarofficial tmsagarofficial linked a pull request Oct 15, 2023 that will close this issue
Open
@nagarajpandith
Copy link
Member

nagarajpandith commented Oct 16, 2023 •
edited
Loading

there is usage of tag for all of the links here. you need to replace them with traditional anchor tag <a> if their href points to external sites (like instagram, facebook etc.). if it's internal routing (like Home, Team, Events etc.), just keep them as it is with the <Link> tag.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@nandanpi nandanpi

@tmsagarofficial tmsagarofficial

Labels
good first issue Good for newcomers low-priority low priority issue compared to others already present
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated social links tmsagarofficial/flc-website
3 participants
@nandanpi @nagarajpandith @tmsagarofficial