Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Weapon self-buffs don't apply when opponent is killed and can't counter #690

Open
masterofcontroversy opened this issue Oct 30, 2024 · 0 comments
Labels
Bug Issues pertaining to bugs. Core Features Issues pertaining to the core functions of the Skill System, its skills, or its dependencies.

Comments

@masterofcontroversy
Copy link
Contributor

Weapon self-buffs are not applied if the opponent is killed in a combat where they cannot counter.
The cause appears to be that, due to its hook address, SetDebuffs is only called if the battle target can counter, and SealSkills will not apply weapon debuffs if either unit died in combat.

The following tests were done by turning debuff 0x5 into a buff using the WepBuffEntry macro, then applying it to the iron bow.

When the enemy is unable to counter and is killed:
NoBuff

When the enemy is able to counter:
Counter

When the enemy is not killed:
Buff

@sme23 sme23 added Bug Issues pertaining to bugs. Core Features Issues pertaining to the core functions of the Skill System, its skills, or its dependencies. labels Jan 5, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Bug Issues pertaining to bugs. Core Features Issues pertaining to the core functions of the Skill System, its skills, or its dependencies.
Projects
None yet
Development

No branches or pull requests

2 participants