Remove QLI. #6840
Merged
Remove QLI. #6840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Anyone against merge this? |
|
Merge it. |
mrotteveel
reviewed
Jun 20, 2021
Comment on lines
-265
to
-268
| build_dbs_: $(MSG_DB) $(HELP_DB) $(META_DB) | ||
| build_dbs_clean: | ||
| rm -f $(MSG_DB) $(HELP_DB) $(META_DB) | ||
| build_dbs_%: |
There was a problem hiding this comment.
Maybe I'm missing something, but shouldn't this remain for $(MSG_DB)?
There was a problem hiding this comment.
I'm not sure this file should even exist.
mrotteveel
reviewed
Jun 20, 2021
| @@ -2,33 +2,33 @@ set bulk_insert INSERT INTO TRANSMSGS (ENG_TEXT, ENG_ACTION, ENG_EXPLANATION, FA | |||
| -- Notice LOCALE is hardcoded as 'de_DE' in the INSERT statement and therefore the rows below have one fields less than the table. | |||
| -- JRD | |||
| ('', NULL, NULL, 0, 0, '', NULL, NULL, 'daves', '1993-07-16 12:15:54') | |||
| ('arithmetic exception, numeric overflow, or string truncation', NULL, NULL, 0, 1, 'Arithmetischer Fehler, numerischer �berlauf oder Zeichenkette abgeschnitten', NULL, NULL, 'daves', '1993-07-16 12:16:07') | |||
There was a problem hiding this comment.
These changes seem to have corrupted the character encoding of the file.
asfernandes
added a commit
that referenced
this pull request
Jun 21, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.