Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Validator] The validator shouldn't report an error of missing an required element when a "data-absent-reason" extension is present #127

Closed
mmsmits opened this issue Feb 4, 2021 · 1 comment
Assignees

Comments

@mmsmits
Copy link
Member

mmsmits commented Feb 4, 2021

Describe the bug
The validator currently reports an error when an element with a cardinality of 1...1 is missing , however this is allowed when there is a "data-absent-reason" extension present instead.

To Reproduce
Run the RunSingleTest() test method in ValidationManifestTest.cs using allergy.json in the R4 branch for a test that checks for this.

Expected behavior
Don't throw an error on a missing element when the data-absent-reason extension is present.

Version used:

  • FHIR Version: STU3, R4, R5

Additional context
This issue/feature has come to light comparing the Java validator against the .NET validator.

@marcovisserFurore marcovisserFurore transferred this issue from FirelyTeam/firely-net-sdk Jul 20, 2023
@mmsmits mmsmits assigned mmsmits and unassigned mmsmits Aug 7, 2023
@mmsmits mmsmits self-assigned this Aug 21, 2023
@mmsmits
Copy link
Member Author

mmsmits commented Aug 21, 2023

After investigating this.
No error is thrown when providing for a missing element, but only for not providing a code for an element that has a required binding. Just like the java validator does. No fix needed.

@mmsmits mmsmits closed this as completed Aug 21, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant