Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Source] A failing ResolveByUri (etc) should throw, not return null #422

Closed
ewoutkramer opened this issue Sep 6, 2017 · 2 comments
Closed
Assignees

Comments

@ewoutkramer
Copy link
Member

We need ResolveXXX() to throw on error (for errors occuring at resolution time - for more static errors discovered by the source, use #421) - and let "null" be returned when the source simply does not have the requested url.

For the MultiResolver - this would mean either

  • On exception - try the other sources, if all fail return the first exception
  • Or create a new MultiResolverResolutionException with a list of all exceptions encountered (much like the AggregateException on Task)
@ewoutkramer
Copy link
Member Author

The new Async resolvers will return Result, instead of throwing or returning null.

@ewoutkramer ewoutkramer self-assigned this May 7, 2020
@marcovisserFurore
Copy link
Member

Discussed in our stand-up of March 4th, 2021. It is a good idea, but IResourceResolver is used everywhere and altering the signature of this interface would break of lot things in the code of the SDK and also in the code of our users. We missed the opportunity to solve this when we've made this Async, but there was too less time for doing this. Therefor, we close this issue.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants