Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support for subdirectories in results-dir #1309

Closed
julioz opened this issue Nov 10, 2020 · 1 comment · Fixed by #1323
Closed

Support for subdirectories in results-dir #1309

julioz opened this issue Nov 10, 2020 · 1 comment · Fixed by #1323

Comments

@julioz
Copy link

julioz commented Nov 10, 2020

Author the user story for this feature

As an engineer, I want to organize results from different flank runs so I can organize and simplify navigation in my Google Cloud Storage bucket.

On our pipelines we run multiple flank setups for different apps and use Fladle for the integration with Gradle.
I have configured each of the fladle blocks with the lines similar to the following:

fladle {
  ...
  resultsDir = "${readFlankResultDirectoryName()}/my-app-test-run-results"
}

In order to have multiple separate directories under the GCS bucket so that the test result artifacts (JUnitReport, MatrixResults, CostReport) don’t overwrite each other.

Describe the solution

Assuming I have 2 flank runs in a single pipeline, what I want to achieve is

gs://<bucket-name>/<pipeline-run>/<flank-run-1>/<artifact.txt>
gs://<bucket-name>/<pipeline-run>/<flank-run-2>/<artifact.txt>

Describe alternatives considered

What I could do as a workaround is to define a namespace to add as part of my bucket directory name.

Right now I still have to do something like

gs://<bucket-name>/<pipeline-run-flank-run-1>/<artifact.txt>
gs://<bucket-name>/<pipeline-run-flank-run-2>/<artifact.txt>

This is not optimal for dev. experience within my company because engineers have to search for all these directories on the root of my bucket that happen to be related. That is why I would rather organize each pipeline run into a single directory with nested directories for each flank run.

@julioz julioz added the Feature label Nov 10, 2020
@piotradamczyk5
Copy link
Contributor

I made similar logic in #1292, so maybe we could generalize it a little bit

@piotradamczyk5 piotradamczyk5 self-assigned this Nov 12, 2020
@piotradamczyk5 piotradamczyk5 added New Option Used to track PR with new configuration option (useful when updating fladle) Tiger 🐯 labels Nov 13, 2020
@mergify mergify bot closed this as completed in #1323 Nov 17, 2020
@pawelpasterz pawelpasterz removed the New Option Used to track PR with new configuration option (useful when updating fladle) label Jan 11, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants