Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Data scratch - file reference #1759

Closed
jan-goral opened this issue Mar 29, 2021 · 1 comment · Fixed by #1841
Closed

Data scratch - file reference #1759

jan-goral opened this issue Mar 29, 2021 · 1 comment · Fixed by #1841

Comments

@jan-goral
Copy link
Contributor

Plan

According to the specification described in epic #1727
add abstraction and implementation for the following part of the data layer:

Abstraction

ftl/data/FileReference.kt

package ftl.data

val downloadFileReference: FileReference.Download get() = TODO()
val uploadFileReference: FileReference.Download get() = TODO()
val existFileReference: FileReference.Exist get() = TODO()

data class FileReference(
    val local: String = "",
    val remote: String = ""
) {
    interface Download : (FileReference) -> FileReference
    interface Upload : (FileReference) -> FileReference
    interface Exist : (FileReference) -> Boolean
}

Target

  • FileReference.kt

Adapter

ftl/adapter/GoogleFileReference.kt

Note

Consider reuse or expand RemoteStorage implementation.

@Sloox
Copy link
Contributor

Sloox commented Apr 13, 2021

blocked by: #1753

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants