We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
max-test-shards
Describe the bug When selecting max-test-shards of -1, flank sets 500 for all virtual devices. According to test lab rest documentation when using arm virtual devices the limit is actually 100 https://firebase.google.com/docs/test-lab/reference/testing/rest/v1/projects.testMatrices#uniformsharding
-1
500
100
I presume this is function which would need to be changed, but I'm not too familiar with the flank codebase. https://github.com/Flank/flank/blob/master/test_runner/src/main/kotlin/ftl/args/PrepareAndroidCommonConfig.kt#L24
To Reproduce
device: - model: SmallPhone.arm version: 30 locale: en orientation: portrait
max-test-shards: 500
Expected behavior I expect flank to determine that arm devices are present and therefore select 100 as the max-test-shards.
Details (please complete the following information): version: v23.06.2 revision: c7bd980
Additional context None
The text was updated successfully, but these errors were encountered:
🙌 Thank you for turning this around so quickly.
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
Describe the bug
When selecting
max-test-shards
of-1
, flank sets500
for all virtual devices. According to test lab rest documentation when using arm virtual devices the limit is actually100
https://firebase.google.com/docs/test-lab/reference/testing/rest/v1/projects.testMatrices#uniformsharding
I presume this is function which would need to be changed, but I'm not too familiar with the flank codebase.
https://github.com/Flank/flank/blob/master/test_runner/src/main/kotlin/ftl/args/PrepareAndroidCommonConfig.kt#L24
To Reproduce
max-test-shards
to-1
Expected behavior
I expect flank to determine that arm devices are present and therefore select
100
as themax-test-shards
.Details (please complete the following information):
version: v23.06.2
revision: c7bd980
Additional context
None
The text was updated successfully, but these errors were encountered: