Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Incorrect outcome for flaky tests [Edge Case] #918

Closed
pawelpasterz opened this issue Jul 30, 2020 · 3 comments · Fixed by #1181 or #1187
Closed

Incorrect outcome for flaky tests [Edge Case] #918

pawelpasterz opened this issue Jul 30, 2020 · 3 comments · Fixed by #1181 or #1187
Assignees

Comments

@pawelpasterz
Copy link
Contributor

pawelpasterz commented Jul 30, 2020

Describe the bug

A clear and concise description of what the bug is.

Sometimes flank's outcome is success when there are flaky tests

To Reproduce

Steps to reproduce the behavior:

So far no reliable way to reproduce it (with 10/10 rate) found. One that gave the same result is to run a test annotated with @Ignore in SavedMatrixTest

Expected behavior

A clear and concise description of what you expected to happen.

If there is at least one flaky test outcome should be flaky as well. The ignored test mentioned earlier must pass.

Details (please complete the following information):

Have you tested on the latest Flank snapshot?

Post the output of flank --version.

Flank v20.07.0

Additional context

Add any other context about the problem here.

It is suspected that in the case of summary=null for both, step and execution, flank is unable to deduce outcome correctly.

This description should be updated in case of any new information.

@Sloox
Copy link
Contributor

Sloox commented Sep 16, 2020

@pawelpasterz looking at this task, can we confirm it is still relevant? The SavedMatrix classes received a large refactor recently and it might have solved the issue.

@pawelpasterz
Copy link
Contributor Author

pawelpasterz commented Sep 30, 2020

@Sloox can't say. It might be as you say. But this bug was really hard to reproduce and non-deterministic even before refactor. We can have some time-box for this issue (like 4h or sth) and if no luck with reproducing, consider as done.

cc @adamfilipow92

@pawelpasterz
Copy link
Contributor Author

@adamfilipow92 please remove the ignored test from SavedMatrixTest suite

# for free to join this conversation on GitHub. Already have an account? # to comment