Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

UI Notification - Not positioning correctly #960

Closed
joepavitt opened this issue Jun 12, 2024 · 5 comments · Fixed by #961
Closed

UI Notification - Not positioning correctly #960

joepavitt opened this issue Jun 12, 2024 · 5 comments · Fixed by #961
Assignees
@joepavitt
Labels
bug Something isn't working size:XS - 1 Sizing estimation point

Comments

@joepavitt
Copy link
Collaborator

Add to that another issue we've had for a couple of versions (but haven't gotten around to reporting) that may or may not be related: we're using several notification popups, about half of them set to display Center on screen, the others are positioned Top Center. Every one of the Center ones, on all dashboards, appear on the bottom center of the screen.

We are using a little CSS code for styling, nothing too fancy, and disabling that makes no difference. I don't think I've seen anyone else complain about this either, although I must admit I haven't been following the new issues as closely as I perhaps should. Or there are few people using the Center setting.
When I set the popup to appear Bottom Center, it appears bottom right. The rest all appears as configured.
And as I said we've seen this for a couple of versions now (somewhere from V1.08 onwards) and I think such a very visual anomaly would be addressed within a version or 2 at most.
If this isn't an already known issue and you can replicate it, I'd be happy to submit an issue for it of course.

Originally posted by @SynoUser-NL in #947 (comment)
@joepavitt joepavitt added size:S - 2 Sizing estimation point bug Something isn't working labels Jun 12, 2024
@joepavitt joepavitt mentioned this issue Jun 12, 2024
Closed
@joepavitt
Copy link
Collaborator Author

Two problems here:

  1. Bottom Center wasn't working because we had a duplicated value - our fault
  2. Center wasn't working because of an underlying Vuetify bug which has since been fixed, so should be in a new version of Vuetify soon

@joepavitt joepavitt mentioned this issue Jun 12, 2024
Merged
@joepavitt joepavitt added size:XS - 1 Sizing estimation point and removed size:S - 2 Sizing estimation point labels Jun 12, 2024
@joepavitt joepavitt self-assigned this Jun 12, 2024
@joepavitt joepavitt moved this from Backlog to Under Review in Dashboard Backlog Jun 12, 2024
@github-project-automation github-project-automation bot moved this from Under Review to Done in Dashboard Backlog Jun 12, 2024
@SynoUser-NL
Copy link

As of DB2 version 1.12.4 this issue remains unsolved in our instances.

@SynoUser-NL SynoUser-NL mentioned this issue Jul 11, 2024
Closed
@joepavitt
Copy link
Collaborator Author

@SynoUser-NL which of "Bottom Center" and "Center" isn't working?

The former we fixed, the latter, the underlying bug sits with Vuetify. I can try and introduce a workaround

@joepavitt
Copy link
Collaborator Author

Although it seems Vuetify have fixed their bug, so we may just need the relevant version bump on our side.

@SynoUser-NL
Copy link

@joepavitt
ah yes.. Positioning a notification in Center still shows on the bottom of the screen. Bottom Center we don't actively use.
Introducing a workaround would not be necessary, better to change the root cause of course.

@joepavitt joepavitt mentioned this issue Jul 11, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@joepavitt joepavitt

Labels
bug Something isn't working size:XS - 1 Sizing estimation point
Projects
Dashboard Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

UI Notification - FIx the "bottom center" location option FlowFuse/node-red-dashboard
2 participants
@SynoUser-NL @joepavitt