Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bug in fluid_synth_sysex_midi_tuning #127

Closed
derselbst opened this issue Aug 17, 2014 · 0 comments
Closed

Bug in fluid_synth_sysex_midi_tuning #127

derselbst opened this issue Aug 17, 2014 · 0 comments
Assignees
Milestone

Comments

@derselbst
Copy link
Member

Hi,

There is a bug in fluid_synth_sysex_midi_tuning (src/synth/fluid_synth.c). The message length check at line 1369 should be

len != data[6] * 4 + 7

(rather than len != data[5] * 4 + 7)

The code is probably copy-pasted from MIDI_SYSEX_TUNING_NOTE_TUNE at line 1361, but since the MIDI_SYSEX_TUNING_NOTE_TUNE_BANK has the bank number BEFORE the key count, the key count is stored in data[6] rather than data[5].

Regards,
Erik Ronström

Reported by: erikronstrom

Original Ticket: fluidsynth/tickets/129

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

2 participants