You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is a bug in fluid_synth_sysex_midi_tuning (src/synth/fluid_synth.c). The message length check at line 1369 should be
len != data[6] * 4 + 7
(rather than len != data[5] * 4 + 7)
The code is probably copy-pasted from MIDI_SYSEX_TUNING_NOTE_TUNE at line 1361, but since the MIDI_SYSEX_TUNING_NOTE_TUNE_BANK has the bank number BEFORE the key count, the key count is stored in data[6] rather than data[5].
Hi,
There is a bug in fluid_synth_sysex_midi_tuning (src/synth/fluid_synth.c). The message length check at line 1369 should be
len != data[6] * 4 + 7
(rather than len != data[5] * 4 + 7)
The code is probably copy-pasted from MIDI_SYSEX_TUNING_NOTE_TUNE at line 1361, but since the MIDI_SYSEX_TUNING_NOTE_TUNE_BANK has the bank number BEFORE the key count, the key count is stored in data[6] rather than data[5].
Regards,
Erik Ronström
Reported by: erikronstrom
Original Ticket: fluidsynth/tickets/129
The text was updated successfully, but these errors were encountered: