Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Zenodo release and conda-forge #14

Open
tpeulen opened this issue Oct 24, 2019 · 3 comments
Open

Zenodo release and conda-forge #14

tpeulen opened this issue Oct 24, 2019 · 3 comments

Comments

@tpeulen
Copy link
Member

tpeulen commented Oct 24, 2019

The source code is now tight to Zenodo releases. However, the Zenodo release does not do a git clone --submodule.

Hence, due to the dependency on thirdparty submodules LabelLib cannot be built with the Zenodo release alone.

I know, this is not very elegant, however, to make it possible to build LabelLib using the Zenodo release alone and to address the issue that conda-forge wants releases to be build from tarballs as opposed to git repositories, we should consider coping the dependencies instead of using submodules.

This would solve issues with conda-forge and zenodo alike.

For the next release we could/should link labellib to Zenodo (see: link). This way, LabelLib gets a DOI and could be cited.

Originally posted by @tpeulen in #11 (comment)

@mdimura
Copy link
Member

mdimura commented Oct 24, 2019

Since thirdparty/Eigen and thirdparty/pybind11 are only used as fallback, it should be sufficient to explicitly copy pcg-cpp, which we totally could do. And for conda-forge we could use automatic github tarballs, which are generated for any github release.

@mdimura
Copy link
Member

mdimura commented Feb 26, 2021

The issue can be discussed in #19

@mdimura mdimura closed this as completed Feb 26, 2021
@tpeulen tpeulen reopened this Jul 4, 2021
@tpeulen
Copy link
Member Author

tpeulen commented Jul 4, 2021

I just submitted labellib to conda-forge. There was in issue with the windows build. Hence, I skip the Windows build for now. see conda-forge/staged-recipes#15497

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants