Merge pull request #8 from FluxML/dg/rename

Remove noarg constructors for some optimisers

Author: DhairyaLGandhi

src/rules.jl

@@ -28,8 +28,6 @@ struct Momentum{T,S}
   rho::S
 end
 
-Momentum(η = 0.01, ρ = 0.9) = Momentum{typeof(η), typeof(ρ)}(η, ρ)
-
 function apply(o::Momentum, x, Δ, st)
   η, ρ = o.eta, o.rho
   v = st
@@ -49,8 +47,6 @@ struct Nesterov{T,S}
   rho::S
 end
 
-Nesterov(η = 0.001, ρ = 0.9) = Nesterov{typeof(η), typeof(ρ)}(η, ρ)
-
 init(o::Nesterov, x::AbstractArray) = zero(x)
 
 function (o::Nesterov)(m, m̄, state)
@@ -72,7 +68,6 @@ struct RMSProp{T,S}
 end
 
 init(o::RMSProp, x::AbstractArray) = zero(x)
-RMSProp(η = 0.001, ρ = 0.9) = RMSProp{typeof(η), typeof(ρ)}(η, ρ)
 
 function apply(o::RMSProp, x, Δ, st)
   η, ρ = o.eta, o.rho

test/runtests.jl

@@ -5,7 +5,7 @@ using Statistics
 @testset "Optimisers" begin
   Random.seed!(84)
   w′ = rand(3,3)
-  @testset for o in (Descent(0.1), Momentum(), Nesterov(), RMSProp(),
+  @testset for o in (Descent(0.1), Momentum(0.01, 0.9), Nesterov(0.001, 0.9), RMSProp(0.001, 0.9),
                      ADAM(0.001, (0.9, 0.99)))
     w = rand(3,3)
     st = Optimisers.init(o,w)