Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Box and derived type should be immutable #404

Open
9 tasks
Orace opened this issue May 23, 2023 · 1 comment
Open
9 tasks

Box and derived type should be immutable #404

Orace opened this issue May 23, 2023 · 1 comment

Comments

@Orace
Copy link
Contributor

Orace commented May 23, 2023

Box and derived type should be immutable.
This property setters and methods should only be called in the constructor / at init:

  • Add
  • Source
  • Foreground
  • Background
  • Italic
  • Width
  • Height
  • Depth
  • Shift
@ForNeVeR
Copy link
Owner

Yep, I approve this. We've been having a similar problem with Atom type, and that's been resolved recently (with C# records). I think a similar approach should work for boxes?

Keep an eye on how selected boxes highlighting works, though. I remember something weird about that.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

2 participants