Skip to content
This repository has been archived by the owner on Feb 19, 2022. It is now read-only.

Can I be of service with React 16? #120

Open
ScriptedAlchemy opened this issue May 25, 2018 · 17 comments
Open

Can I be of service with React 16? #120

ScriptedAlchemy opened this issue May 25, 2018 · 17 comments

Comments

@ScriptedAlchemy
Copy link

ScriptedAlchemy commented May 25, 2018

@divmain
@aweary

Heya Dale! Im know you guys have your hands full. I wanted to know if theres anything I can do to assist with React 16 support?

Pretty much, have you guys given it any thought? I know React16 solves many problems that you guys had worked tirelessly to handle inside rapscallion. But theres still one major area that I can see this project living on and servicing very will... Fragment cacheing and caching in general!

Im currently invested in some of my own cacheing efforts, but I was wondering if you guys have some direction / need a hand in getting rapscallions cache to accept and render React 16?

One cache I came across: https://github.com/zackljackson/react-component-caching
Could this be retrofitted into rapscallion? At lest the renderer?

Id love to know your thoughts and if you are in need of a helping hand, I can try to rally and crowdsource / lead the React 16 update

@divmain
Copy link
Contributor

divmain commented Jul 5, 2018

Hey @ScriptedAlchemy - sorry for dropping the ball on replying to you! Help moving forward with React 16 would be much appreciated. You still interested?

@ScriptedAlchemy
Copy link
Author

No worries, yeah I’d still be down to do it. I just relocated to Seattle, so I’ve got more downtime to contribute to open-source. (AKA: no job)😂😂

If I do the upgrade, anyone watching enough to merge it? Not a huge amount of activity in recent months - ill do it, for sure, just wanna make sure someone who has write access is around

@ScriptedAlchemy
Copy link
Author

@divmain ☝️

Also is there a better way to reach you?

@tannerlinsley
Copy link

@ScriptedAlchemy is this what react-static needs? ;) I just tried to install and test and realized it wasn't 16 compatible... :(

@ScriptedAlchemy
Copy link
Author

I was gonna upgrade it for them, but formidable doesn’t seem to be too active - my fear is doing the work and the PR never merges.

I was gonna take rookLabs and patch it’s conciliation engine into this

@ScriptedAlchemy
Copy link
Author

I have write access to rookLabs, we can work as we need to on it if need be

@88kami88
Copy link
Contributor

I'm going to try to get my merge access sorted out and if so I can work with you on this.

@ScriptedAlchemy
Copy link
Author

I just started a new job, so im a little constrained this week and next. But if we can sort out consistent write access (dont care who) - ill help maintain it

@ryan-roemer
Copy link
Member

@ScriptedAlchemy @ethersage -- Thanks for the contributions and work! @boygirl (our OSS lead) and I really need to touch base with @divmain (the lead maintainer, currently at another company) and get our support story straight on this project (and https://github.com/FormidableLabs/freactal).

We will update by sometime next week with a path forward that hopefully works with your uses!

@ryan-roemer
Copy link
Member

Hi @ScriptedAlchemy,

Formidable as been in a bit of holding pattern on this repo, and we'd like to enable the community to get back to it and hopefully pick up the reins on this project (with our background support). And we are excited to see @ethersage 's great work all around and cleaning things up / modernizing stuff.

For this specific issue, we'd love to have an upgrade PR. I've done a few of these updates, and can help pitch in to support whatever you need here (clicking buttons, publishing, as well as any infrastructure stuff like quality / build stuff).

And, after this issue, if you're up for it, we're looking for additional active maintainers and would love to have you on board.

Thanks!

@ScriptedAlchemy
Copy link
Author

Hey! Great to see this roar back to life. If there’s not already readily available maintainers. I’ll definitely # for one.

Im fully on board to maintain this a long time. Half my product line is about to be merged into Suspense. So I’ll only look after react static RFR and Rudy, I’ve reversed engineered your code to do some crazy things. I was able to put-perform backend fragment caches. It was work, but I can do most of it again. Coupled with some customizations to how iterators garbage collect. I anticipate single digit responses. Even with remote stores, and have achieved this by monkey patching.

I’d like internalize some better cache structures - design a hybrid LRU and remote store. In memory and on disk caching.

Coupling this with rooklabs the main thing is we need to pass cache keys from rapscallion to my new one. If we can pull it off then I offer templatization. Nano second render times.

If I can get some stable communication line with formidable/ write access / someone you trust to have write access. Then I’m gonna open elaborate a blueprint on this issue. Then start pushing PRs,

Rapscallion is very useful for a special architecture called Rudy. You can check my repo and find a link to it via redux first router.

React static needs it too

I like drawing how it works on a whiteboard for people

Anyways. I’m a tad bit busy replying to a bunch of urgent messages. This is in the queue but I need to finish some work, write a reply to one of my maintainers. And then I should start drudge get through the codebase again. Anyone who can amor wants to join my efforts. Feel free.

I’ll perform the upgrade and have had my own architectural overhauls in mind, I’d kinda written it off - but if I can get stable PRs merged. And if someone is sited of dealing with issues or the repo. Please consider passing it to a dev who can keep it alive.

It’s arxhitecture offers multiple avenues of more elaborate async capabilities.

@ScriptedAlchemy
Copy link
Author

And if there’s any formidable people at my company. Let’s grab lunch

@ScriptedAlchemy
Copy link
Author

Also. I’ve got a few reports which are “the communities responsibility .”

I refer to it is as entering LTS

Myself Would enjoy bringing back as a active dev into.

Lmk, I’m down next week to start pigsinf blueprints. I am thinly stretched, but this is a project that I’ve had to re engineer a few times. Internal fixes are good. Plus I brink enterprise scale and will ensure your original friend handle millions of requests

@ryan-roemer
Copy link
Member

@ethersage @ScriptedAlchemy -- Just to place a note here: I'm down to support either of you kicking things off if y'all have a mutually agreed "next step" for the project! You're both maintainers now, so there are no structural impediments and I can help with anything infrastructure / support / whatever.

Cheers!

@ScriptedAlchemy
Copy link
Author

Thanks! I’m likely to open an issue with initial planned idea to patch R16 into it. Your input will be helpful as I’ve mostly monkey ptched via elaborate wrappers, internally it’s been a year since.

Honestly I think it’s a case of we hammer out the issue and plan. Then just start doing as we have time. I am actively working to reduce my OSS workload so I can pick up here.

@kitten
Copy link

kitten commented Mar 29, 2019

@ScriptedAlchemy @ethersage Hiya, we currently have a new library that's called react-ssr-prepass that might help in implementing a new traverser. It does not have any stringification logic, but that can be pieced together from what's implemented in rapscallion already or react-dom's ReactPartialRenderer, which is what react-ssr-prepass is based on. https://github.com/FormidableLabs/react-ssr-prepass

If you're looking into patching rapscallion, let me know if react-ssr-prepass can be a good source of information or whether you need any other insights on what needs to be updated 👍

cc @ryan-roemer

@ScriptedAlchemy
Copy link
Author

Awesome, I’ll check it out! I’ve not been able to get to this task because I’ve not had a use case or business reason to update it.

However that might change in the next 2 months - if so I’ll be getting to the upgrade. I’m also in talks with the maintainer of React hot loader who might collaborate on this upgrade

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants