Replace fast-json-stable-stringify #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitten
commented
Sep 16, 2019
|
|
||
| const stringify = (x: any): string => { | ||
| if (x === undefined) { | ||
| return ''; |
There was a problem hiding this comment.
divergence from fast-json-stable-stringify: We don't expect to stringify undefined, so we can just return an empty string here, which makes the return type consistently a string and simplifies lines 19 and 34
kitten
force-pushed
the
chore/replace-fast-json-stringify
branch
from
74a70f5 to
14fc98b
Compare
kitten
force-pushed
the
chore/replace-fast-json-stringify
branch
from
14fc98b to
5a24abf
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem with having
fast-json-stable-stringifyis that it's the only package that doesn't support ESM. This means that by using it we completely forgo the possibility of supporting ESM browser imports even forurql/corein the future.This replaces the package with an embedded implementation that works the exact same. It's exported so that it can be reused in
@urql/exchange-graphcache, however it works the same, so it's completely backwards compatible.This also shaves off some bytes, since we're getting rid of some options and configuration in
fast-json-stable-stringifythat we don't need.