Replace useImmediate* hooks with react-wonka #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's probably fair to bundle this for now. It's tiny and this way we can compare the bundlesize to before (+.02kB min+gzip)
kitten
commented
Oct 10, 2019
| @@ -25,7 +24,8 @@ export const useMutation = <T = any, V = object>( | |||
| query: DocumentNode | string | |||
| ): UseMutationResponse<T, V> => { | |||
| const client = useClient(); | |||
| const [state, setState] = useImmediateState<UseMutationState<T>>({ | |||
|
|
|||
| const [state, setState] = useState<UseMutationState<T>>({ | |||
There was a problem hiding this comment.
Small note on this change; This is not a breaking change. Since mutations are realistically run only after a component has mounted, useImmediateState was never doing anything here
This gets rid of some of the internal structures and functions in favour of a simpler Source memo.
kitten
force-pushed
the
refactor/use-react-wonka
branch
2 times, most recently
from
e269a64 to
085ab12
Compare
JoviDeCroock
approved these changes
Oct 10, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to improve the stability of our hooks and ensure that we won't run into problems with concurrent mode in the future. At its core is a tiny library I've written,
react-wonka. https://github.com/kitten/react-wonkaIt takes care of transforming changing inputs to streams and using the given output stream to then return output values from its hooks, synchronously if possible, and with updates if not.
It is aware of concurrent mode and uses an internal counter to trigger updates, which seems to be popular these days 😓
It's tests are more thorough than what we could write realistically for each of our hooks: https://github.com/kitten/react-wonka/blob/master/src/index.test.ts
In practice this may even make
useQueryanduseSubscriptionlook a little nicer, if someone is open to help me tweak the implementation a little. Doesn't look 100% pretty yet 😅In practice, our bundle-size only changes by
+0.02kB min+gzip(this branch compared to the last release) when I'm includingreact-wonkain the bundle, which seems better for a fair comparison.This should also improve our handling of suspense. Our
useImmediateEffecthook runs normal effects after the initial mount. When we update a hook we'd right now throw a suspense-promise in a normal effect, which is not allowed.