Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allow stale to be returned by exchanges #449

Merged
merged 3 commits into from
Oct 11, 2019
Merged

Conversation

kitten
Copy link
Member

@kitten kitten commented Oct 11, 2019

This adds a new stale?: boolean flag to OperationResult that exchanges can use to indicate whether they're still fetching more data in the background (like with cache-and-network or graphcache's partial results)

Hooks will normalise this flag to stale: boolean and pass it through to their results.

This supersedes: #444

@kitten kitten requested a review from JoviDeCroock October 11, 2019 16:25
Copy link
Collaborator

@JoviDeCroock JoviDeCroock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! 💯

@kitten kitten merged commit af876b8 into master Oct 11, 2019
@kitten kitten deleted the feat/add-stale-to-result branch February 6, 2020 19:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants