Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Provide documentation about when to create a new node type #1739

Open
oxisto opened this issue Sep 27, 2024 · 1 comment
Open

Provide documentation about when to create a new node type #1739

oxisto opened this issue Sep 27, 2024 · 1 comment
Assignees
Labels
discussion Label for issues or future features to be discussed before putting them onto the road-map

Comments

@oxisto
Copy link
Member

oxisto commented Sep 27, 2024

Maybe place here: https://github.com/Fraunhofer-AISEC/cpg/blob/main/docs/docs/Contributing/index.md#code-guidelines

Some guidelines from @maximiliankaul. It is ok to add a new node type if:

  • It is not possible to otherwise realise this construct
  • The concept is known in at least 2 langauges
  • It will significantly ease the live of the developers, e.g., in terms of maintainability
@oxisto oxisto added the discussion Label for issues or future features to be discussed before putting them onto the road-map label Sep 27, 2024
@maximiliankaul
Copy link
Contributor

⬆️ just something that came up in another chat. If one of these conditions is true, then we should consider a new node. If non of them are true -> no need for a new node.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
discussion Label for issues or future features to be discussed before putting them onto the road-map
Projects
None yet
Development

No branches or pull requests

3 participants