ungit throws error at startup and quits

[guillaumedavidphd]

I haven't been able to run ungit since the last update. I get the following error:

internal/modules/cjs/loader.js:596

throw err;
^

Error: Cannot find module 'editions'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:594:15)
    at Function.Module._load (internal/modules/cjs/loader.js:520:25)
    at Module.require (internal/modules/cjs/loader.js:650:17)
    at require (internal/modules/cjs/helpers.js:20:18)
    at Object.<anonymous> (C:\Users\<username>\AppData\Roaming\npm\node_modules\ungit\node_modules\getmac\index.js:4:18)
    at Module._compile (internal/modules/cjs/loader.js:702:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:713:10)
    at Module.load (internal/modules/cjs/loader.js:612:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:551:12)
    at Function.Module._load (internal/modules/cjs/loader.js:543:3)

The module editions is installed globally, and so is ungit.

[SDohle]

I get the same error (ungit@1.4.32)

[ylecuyer]

Which version of node/npm are you using?

Please refer to https://github.com/FredrikNoren/ungit/blob/master/CONTRIBUTING.md

Posting issues
Just common sense; do a quick search before posting, someone might already have created an issue (or resolved the problem!). If you're posting a bug; try to include as much relevant information as possible (ungit version, node and npm version, os, any git errors displayed, the output from CLI console and output from the browser console).

[guillaumedavidphd]

ungit@1.4.32
node@10.3.0
npm@6.4.0
os: Win10

[balupton]

getmac and editions are my packages. Could the author please try updating getmac to 1.4.4 as the debugging info users have provided is for getmac 1.4.1

[guillaumedavidphd]

I've updated getmac to 1.4.4. Probem is still here.

[balupton]

Mind if I remote in and debug it with you? Not sure the issue is on my side, but happy to look into it as it is my package after all.

[balupton]

Ok. I think I miss configured something with editions. Let me push up a fix. One moment. Strange errors are now only coming in, as the version is a few weeks old.

[balupton]

v1.4.5 of getmac will be published as soon as https://travis-ci.org/bevry/getmac/builds/419868038 passes - let me know if that resolves the issue

edit, now published

[tony90018]

I've updated getmac to 1.4.5. But the problem still exists.

[balupton]

I will need to remote into your machine to debug, as I am unable to reproduce. Grab a time on https://balupton.com/meet and we’ll work it out

[balupton]

Also interesting that all reports are for windows. Is anyone encountering this not on windows?

Will try and get a windows VM going. Perhaps it is an issue with using colon in directory names, affecting the node resolution system or the npm bundles.

[ylecuyer]

I tried on ubuntu 18.04 with the exact same versions and I didn't had problems

[balupton]

So turns out it is because Windows doesn't support : in filenames, it seems however npm is still able to install the packages on Windows as it converts : on those platforms to  which shows as a dot character.

I can work around this issue by not using : in filenames, however it seems that the node module resolution system should have a workaround for what npm has done.

[balupton]

Crossposted on the npm forum for advice

https://npm.community/t/packages-published-on-unix-with-in-filenames-fail-to-be-loaded-on-windows/1682?u=balupton

[balupton]

I'll see what they say. Regardless, I'll push up a workaround (using underscores instead of colons) tomorrow. Sorry for the stuff up everyone.

[jung-kim]

Thanks for diving into this issue in details, and this seems like a tricky issue.

Considering getmac@1.4.5 is still having some issue I will not cut the new version with this yet.

Once again, thanks for the prompt response!

[jung-kim]

(and sorry I've been unresponsive as this is a very busy week for my company... :( )

[balupton]

Came off my motorbike today and got a bit scraped up. So will get to this in a day or two. Sorry for the delay.

In the meantime, you can pin getmac to an earlier version, perhaps 1.4.4 or 1.4.3

[balupton]

Hand got infected and had to return to Australia for treatment. Will be another day or so. I'm really sorry for the delays.

[mastermind3043-zz]

+1 facing the same issue

[per2mn]

Also facing the same issue since many days (weeks?).
Seems that npm plugin 'editions' is not Windows compatible because of a ':' in the plugin name or dir???

[balupton]

Correct. I will get to it when I can, so far I have been too injured. Things are finally getting better though.

For the meantime, pin getmac to an earlier version.

[jung-kim]

@balupton Will downgrading to getmac@1.4.3 and locking it to that version work?

[balupton]

getmac 1.4.6 is incoming which will resolve this issue

if you experience it again, clear your npm cache and try again

[guillaumedavidphd]

Looks like ungit is fixed for me thanks to @balupton. Please reopen if someone is still affected.