Fix for Warning: ini_set(): A session is active. You cannot change the session module's ini settings at this time

Author: Sergey Matvienko

lib/config/config/factories.yml

@@ -29,6 +29,7 @@ default:
   user:
     class: myUser
     param:
+      timeout:         1800
       logging:         %SF_LOGGING_ENABLED%
       use_flash:       true
       default_culture: %SF_DEFAULT_CULTURE%
@@ -37,7 +38,6 @@ default:
     class: sfSessionStorage
     param:
       session_name: symfony
-      timeout:      1800
 
   view_cache_manager:
     class: sfViewCacheManager

lib/config/sfFactoryConfigHandler.class.php

@@ -109,6 +109,12 @@ public function execute($configFiles)
             unset($parameters['database']);
           }
 
+          $sessionGcMaxlifetime = 1800;
+          if (isset($config['user']['timeout'])) {
+            $sessionGcMaxlifetime = $config['user']['timeout'];
+          }
+          $defaultParameters[] = sprintf("'gc_maxlifetime' => %d,", $sessionGcMaxlifetime);
+
           $instances[] = sprintf("  \$class = sfConfig::get('sf_factory_storage', '%s');\n  \$this->factories['storage'] = new \$class(array_merge(array(\n%s\n), sfConfig::get('sf_factory_storage_parameters', %s)));", $class, implode("\n", $defaultParameters), var_export($parameters, true));
           break;
 

lib/storage/sfSessionStorage.class.php

@@ -68,9 +68,9 @@ public function initialize($options = null)
     // initialize parent
     parent::initialize($options);
 
-    if (!array_key_exists('timeout', $this->options))
+    if (!array_key_exists('gc_maxlifetime', $this->options))
     {
-      $this->options['timeout'] = 1800;
+      $this->options['gc_maxlifetime'] = 1800;
     }
 
     // set session name
@@ -96,9 +96,9 @@ public function initialize($options = null)
     }
 
     // force the max lifetime for session garbage collector to be greater than timeout
-    if (ini_get('session.gc_maxlifetime') < $this->options['timeout'])
+    if (ini_get('session.gc_maxlifetime') < $this->options['gc_maxlifetime'])
     {
-      ini_set('session.gc_maxlifetime', $this->options['timeout']);
+      ini_set('session.gc_maxlifetime', $this->options['gc_maxlifetime']);
     }
 
     if ($this->options['auto_start'] && !self::$sessionStarted)

lib/user/sfBasicSecurityUser.class.php

@@ -248,8 +248,7 @@ public function initialize(sfEventDispatcher $dispatcher, sfStorage $storage, $o
 
     if (!array_key_exists('timeout', $this->options))
     {
-      $storageOptions = $storage->getOptions();
-      $this->options['timeout'] = isset($storageOptions['timeout']) ? $storageOptions['timeout'] : 1800;
+      $this->options['timeout'] = 1800;
     }
 
     // read data from storage