Avoid PHP8 warnings

Author: teymour

lib/helper/DateHelper.php

@@ -17,7 +17,7 @@
  * @version    SVN: $Id$
  */
 
-function format_daterange($start_date, $end_date, $format = 'd', $full_text, $start_text, $end_text, $culture = null, $charset = null)
+function format_daterange($start_date, $end_date, $format = 'd', $full_text = '', $start_text = '', $end_text = '', $culture = null, $charset = null)
 {
   if ($start_date != '' && $end_date != '')
   {

lib/i18n/sfDateFormat.class.php

@@ -239,9 +239,10 @@ public function format($time, $pattern = 'F', $inputPattern = null, $charset = '
       }
       else
       {
-        $function = ucfirst($this->getFunctionName($pattern));
+        $function = $this->getFunctionName($pattern);
         if ($function != null)
         {
+          $function = ucfirst($function);
           $fName = 'get'.$function;
           if (in_array($fName, $this->methods))
           {

lib/routing/sfRoute.class.php

@@ -285,7 +285,7 @@ protected function generateWithTokens($parameters)
       switch ($token[0])
       {
         case 'variable':
-          if (!$optional || !isset($this->defaults[$token[3]]) || $parameters[$token[3]] != $this->defaults[$token[3]])
+          if (!$optional || !isset($this->defaults[$token[3]]) || (isset($parameters[$token[3]]) && isset($this->defaults[$token[3]]) && ($parameters[$token[3]] != $this->defaults[$token[3]])))
           {
             $url[] = urlencode($parameters[$token[3]]);
             $optional = false;
@@ -791,7 +791,7 @@ protected function fixDefaults()
       }
       else
       {
-        $this->defaults[$key] = urldecode($value);
+        $this->defaults[$key] = ($value) ? urldecode($value) : '';
       }
     }
   }

lib/util/sfBrowserBase.class.php

@@ -908,7 +908,7 @@ public function doClickElement(DOMElement $item, $arguments = array(), $options
     }
     else
     {
-      $queryString = http_build_query($arguments, null, '&');
+      $queryString = ($arguments) ? http_build_query($arguments, null, '&') : "";
       $sep = false === strpos($url, '?') ? '?' : '&';
 
       return array($url.($queryString ? $sep.$queryString : ''), 'get', array());

lib/util/sfInflector.class.php

@@ -27,7 +27,9 @@ class sfInflector
    */
   public static function camelize($lower_case_and_underscored_word)
   {
-
+    if (!$lower_case_and_underscored_word) {
+      return $lower_case_and_underscored_word;
+    }
     return strtr(ucwords(strtr($lower_case_and_underscored_word, array('/' => ':: ', '_' => ' ', '-' => ' '))), array(' ' => ''));
   }
 
@@ -41,6 +43,9 @@ public static function camelize($lower_case_and_underscored_word)
   public static function underscore($camel_cased_word)
   {
     $tmp = $camel_cased_word;
+    if (!$tmp) {
+      return '';
+    }
     $tmp = str_replace('::', '/', $tmp);
     $tmp = sfToolkit::pregtr($tmp, array('/([A-Z]+)([A-Z][a-z])/' => '\\1_\\2',
                                          '/([a-z\d])([A-Z])/'     => '\\1_\\2'));

lib/util/sfToolkit.class.php

@@ -366,7 +366,7 @@ public static function replaceConstants($value)
    */
   public static function pregtr($search, $replacePairs)
   {
-    return preg_replace(array_keys($replacePairs), array_values($replacePairs), $search);
+    return ($search) ? preg_replace(array_keys($replacePairs), array_values($replacePairs), $search) : $search;
   }
 
   /**

lib/vendor/lime/lime.php

@@ -564,7 +564,7 @@ protected function find_caller($traces)
     return array($traces[$last]['file'], $traces[$last]['line']);
   }
 
-  public function handle_error($code, $message, $file, $line, $context)
+  public function handle_error($code, $message, $file, $line, $context = null)
   {
     if (!$this->options['error_reporting'] || ($code & error_reporting()) == 0)
     {